Çözüldü Tweeny animation bugs

EnZi · 16 Mart 2024

Hi,

I have a bug with Tweeny Animation.. nearly every window animation work smooth but only windows with items like shop, safebox, offlineshop are glitching.. (inventory works)
They should close smoothly like other windows but instead of smooth close it glitch like it open,close,open,close,open,close.. below is .gif with exact problem.
It may not be easy to see on that .gif, but if someone uses the system they know.

Linkleri görebilmek için giriş yap veya kayıt ol.

Second problem is with auto close windows as shop.. when you get far it wont close a window.

Linkleri görebilmek için giriş yap veya kayıt ol.

Decreasing or increasing this value do nothing.. bug will be still there..

PythonWindow.cpp:

        if (IsFlag(FLAG_ANIMATED_BOARD))
        {
            if (m_bShow)
            {
                m_sizeAnimation = tweeny::from(1.0f)
                    .to(0.0f)
                    .during(120)

Anyone find some fix for any of these problems?

Thanks in advance

themanji · 16 Mart 2024

uishop.py search def close and add

self.RemoveFlag("animate")

EnZi · 17 Mart 2024

themanji demiş ki:
uishop.py search def close and add

self.RemoveFlag("animate")

Mate you are genius.. I had to create that remove flag method in binary but when I did and then remove "animate" from shopdialog.py and add it in LoadWindow + that remove flag in close it works as it should

thanks for that idea

beaudeciuda · 17 Mart 2024

EnZi demiş ki:
Mate you are genius.. I had to create that remove flag method in binary but when I did and then remove "animate" from shopdialog.py and add it in LoadWindow + that remove flag in close it works as it should thanks for that idea

Hi, can you be a little more specific? or a mini-tutorial? thank

EnZi · 17 Mart 2024

beaudeciuda demiş ki:
Hi, can you be a little more specific? or a mini-tutorial? thank

In PythonWindowManagerModule.cpp

Add (but check all flags cause we can have different flags, just delete flags you dont have)!!!

C++:

PyObject* wndMgrRemoveFlag(PyObject* poSelf, PyObject* poArgs)
{
    UI::CWindow* pWin;
    if (!PyTuple_GetWindow(poArgs, 0, &pWin))
        return Py_BuildException();

    char* pszFlag;
    if (!PyTuple_GetString(poArgs, 1, &pszFlag))
        return Py_BuildException();

    if (pszFlag && *pszFlag)
    {
        if (!stricmp(pszFlag, "movable"))
            pWin->RemoveFlag(UI::CWindow::FLAG_MOVABLE);
        else if (!stricmp(pszFlag, "limit"))
            pWin->RemoveFlag(UI::CWindow::FLAG_LIMIT);
        else if (!stricmp(pszFlag, "dragable"))
            pWin->RemoveFlag(UI::CWindow::FLAG_DRAGABLE);
        else if (!stricmp(pszFlag, "attach"))
            pWin->RemoveFlag(UI::CWindow::FLAG_ATTACH);
        else if (!stricmp(pszFlag, "restrict_x"))
            pWin->RemoveFlag(UI::CWindow::FLAG_RESTRICT_X);
        else if (!stricmp(pszFlag, "restrict_y"))
            pWin->RemoveFlag(UI::CWindow::FLAG_RESTRICT_Y);
        else if (!stricmp(pszFlag, "float"))
            pWin->RemoveFlag(UI::CWindow::FLAG_FLOAT);
        else if (!stricmp(pszFlag, "not_pick"))
            pWin->RemoveFlag(UI::CWindow::FLAG_NOT_PICK);
        else if (!stricmp(pszFlag, "ignore_size"))
            pWin->RemoveFlag(UI::CWindow::FLAG_IGNORE_SIZE);
        else if (!stricmp(pszFlag, "rtl"))
            pWin->RemoveFlag(UI::CWindow::FLAG_RTL);
        else if (!stricmp(pszFlag, "alpha_sensitive"))
            pWin->RemoveFlag(UI::CWindow::FLAG_ALPHA_SENSITIVE);
        else if (!stricmp(pszFlag, "remove_limit"))
            pWin->RemoveFlag(UI::CWindow::FLAG_REMOVE_LIMIT);
        else if (!stricmp(pszFlag, "window_without_alpha"))
            pWin->RemoveFlag(UI::CWindow::FLAG_IS_BOARD_WITHOUT_ALPHA);
#ifdef ENABLE_TWEENY_LIBRARY
        else if (!stricmp(pszFlag, "animate"))
            pWin->RemoveFlag(UI::CWindow::FLAG_ANIMATED_BOARD);
#endif
        else
            TraceError("Unknown window flag %s", pszFlag);
    }

    return Py_BuildNone();
}

register it too

C++:

{ "RemoveFlag",                    wndMgrRemoveFlag,                    METH_VARARGS },

In ui.py

Under this

C++:

    def AddFlag(self, style):
        wndMgr.AddFlag(self.hWnd, style)

Add this

C++:

    def RemoveFlag(self, style):
        wndMgr.RemoveFlag(self.hWnd, style)

Now go in uishop.py and add

in def LoadDialog(self): right at start add

C++:

 self.AddFlag("animate")

in def Open(self, vid): right at start add

C++:

 self.AddFlag("animate")

and in def Close(self): under self.Hide()

C++:

self.RemoveFlag("animate")

Thats all.. But if you have in uiscript/shopdialog.py animate flag, remove it..

EDIT: I forgot about second problem

In uishop.py

under imports add

Python:

TEXT_TIME = 3

Search

Python:

self.tooltipItem = 0

add under

Python:

self.textCloseText = 0

Search

Python:

self.ClearDictionary()

add under

Python:

self.textCloseText = 0

Search

Python:

def OnUpdate(self):

Replace with this

Python:

    def OnUpdate(self):
        if app.GetTime() >= self.textCloseText:

            USE_SHOP_LIMIT_RANGE = 1000

            (x, y, z) = player.GetMainCharacterPosition()

            if abs(x - self.xShopStart) > USE_SHOP_LIMIT_RANGE or abs(y - self.yShopStart) > USE_SHOP_LIMIT_RANGE:
                self.textCloseText = app.GetTime() + TEXT_TIME
                self.Close()

beaudeciuda · 17 Mart 2024

EnZi demiş ki:

In PythonWindowManagerModule.cpp

Add (but check all flags cause we can have different flags, just delete flags you dont have)!!!

C++:

PyObject* wndMgrRemoveFlag(PyObject* poSelf, PyObject* poArgs)
{
    UI::CWindow* pWin;
    if (!PyTuple_GetWindow(poArgs, 0, &pWin))
        return Py_BuildException();

    char* pszFlag;
    if (!PyTuple_GetString(poArgs, 1, &pszFlag))
        return Py_BuildException();

    if (pszFlag && *pszFlag)
    {
        if (!stricmp(pszFlag, "movable"))
            pWin->RemoveFlag(UI::CWindow::FLAG_MOVABLE);
        else if (!stricmp(pszFlag, "limit"))
            pWin->RemoveFlag(UI::CWindow::FLAG_LIMIT);
        else if (!stricmp(pszFlag, "dragable"))
            pWin->RemoveFlag(UI::CWindow::FLAG_DRAGABLE);
        else if (!stricmp(pszFlag, "attach"))
            pWin->RemoveFlag(UI::CWindow::FLAG_ATTACH);
        else if (!stricmp(pszFlag, "restrict_x"))
            pWin->RemoveFlag(UI::CWindow::FLAG_RESTRICT_X);
        else if (!stricmp(pszFlag, "restrict_y"))
            pWin->RemoveFlag(UI::CWindow::FLAG_RESTRICT_Y);
        else if (!stricmp(pszFlag, "float"))
            pWin->RemoveFlag(UI::CWindow::FLAG_FLOAT);
        else if (!stricmp(pszFlag, "not_pick"))
            pWin->RemoveFlag(UI::CWindow::FLAG_NOT_PICK);
        else if (!stricmp(pszFlag, "ignore_size"))
            pWin->RemoveFlag(UI::CWindow::FLAG_IGNORE_SIZE);
        else if (!stricmp(pszFlag, "rtl"))
            pWin->RemoveFlag(UI::CWindow::FLAG_RTL);
        else if (!stricmp(pszFlag, "alpha_sensitive"))
            pWin->RemoveFlag(UI::CWindow::FLAG_ALPHA_SENSITIVE);
        else if (!stricmp(pszFlag, "remove_limit"))
            pWin->RemoveFlag(UI::CWindow::FLAG_REMOVE_LIMIT);
        else if (!stricmp(pszFlag, "window_without_alpha"))
            pWin->RemoveFlag(UI::CWindow::FLAG_IS_BOARD_WITHOUT_ALPHA);
#ifdef ENABLE_TWEENY_LIBRARY
        else if (!stricmp(pszFlag, "animate"))
            pWin->RemoveFlag(UI::CWindow::FLAG_ANIMATED_BOARD);
#endif
        else
            TraceError("Unknown window flag %s", pszFlag);
    }

    return Py_BuildNone();
}

register it too

C++:

{ "RemoveFlag",                    wndMgrRemoveFlag,                    METH_VARARGS },

In ui.py

Under this

C++:

    def AddFlag(self, style):
        wndMgr.AddFlag(self.hWnd, style)

Add this

C++:

    def RemoveFlag(self, style):
        wndMgr.RemoveFlag(self.hWnd, style)

Now go in uishop.py and add

in def LoadDialog(self): right at start add

C++:

 self.AddFlag("animate")

in def Open(self, vid): right at start add

C++:

 self.AddFlag("animate")

and in def Close(self): under self.Hide()

C++:

self.RemoveFlag("animate")

Thats all.. But if you have in uiscript/shopdialog.py animate flag, remove it..

and why not solve " void CWindow::Hide() " for all windows instead of adding that flag to each window separately?

EnZi · 17 Mart 2024

beaudeciuda demiş ki:
and why not solve " void CWindow::Hide() " for all windows instead of adding that flag to each window separately?

You cant do much about it but you can try.. I just made it simplier

C++:

    void CWindow::Show()
    {
#ifdef ENABLE_TWEENY_LIBRARY
        if (IsFlag(FLAG_ANIMATED_BOARD))
        {
            if (!this->m_bShow)
            {
                this->m_bShow = true;

                m_sizeAnimation = tweeny::from(0.0f)
                    .to(1.0f)
                    .during(150)
                    .via(tweeny::easing::cubicOut)
                    .onStep([this](tweeny::tween<float>& t, float scale) {
                    SetScale(scale, scale);

                    if (t.progress() == 1.0f)
                    {
                        // Animation completed, set m_bShow to true
                        return true;
                    }
                    else
                    {
                        return false;
                    }
                        });
                m_sizeAnimation.value().step(0.0f);
            }
        }
        else
        {
            m_bShow = true;
        }
#else
        m_bShow = true;
#endif
    }

    void CWindow::Hide()
    {
#ifdef ENABLE_TWEENY_LIBRARY
        if (IsFlag(FLAG_ANIMATED_BOARD))
        {
            if (m_bShow)
            {
                m_sizeAnimation = tweeny::from(1.0f)
                    .to(0.0f)
                    .during(120)
                    .via(tweeny::easing::cubicIn)
                    .onStep([this](tweeny::tween<float>& t, float scale) {
                    SetScale(scale, scale);

                    if (t.progress() == 1.0f)
                    {
                        // Animation completed, set m_bShow to false
                        m_bShow = false;
                        return true;
                    }
                    else
                    {
                        return false;
                    }
                        });
                m_sizeAnimation.value().step(0.0f);
            }
        }
        else
        {
            m_bShow = false;
        }
#else

        m_bShow = false;
#endif
    }

beaudeciuda · 17 Mart 2024

EnZi demiş ki:
You cant do much about it but you can try.. I just made it simplier

Linkleri görebilmek için giriş yap veya kayıt ol.

I redid the source part.. i think its ok now

EnZi · 17 Mart 2024

beaudeciuda demiş ki:
Linkleri görebilmek için giriş yap veya kayıt ol.
I redid the source part.. i think its ok now

And what you did exactly?

Çözüldü Tweeny animation bugs

Diğer Seçenekler

EnZi

Üye

EnZi

themanji

Premium Üye

EnZi

Üye

beaudeciuda

Üye

EnZi

Üye

beaudeciuda

Üye

EnZi

Üye

beaudeciuda

Üye

EnZi

Üye

Benzer konular